Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JavaScript] Implement the standard protocol #1286

Merged
merged 4 commits into from
Jan 2, 2024
Merged

[JavaScript] Implement the standard protocol #1286

merged 4 commits into from
Jan 2, 2024

Conversation

theweipeng
Copy link
Member

  1. Make the tag string lazy to avoid creating strings.
  2. Add the serializeVolatile API to take ownership of the bufferWriter and avoid buffer copying, which is 30% faster than the serialize operation. There is a usage limitation; the bufferWriter remains inaccessible until the dispose method from the result of serializeVolatile has been called.
  3. Remove the useLatin1 configuration, which is a standard in the Fury protocol.

Before:
image

After:
image

@theweipeng
1. make tag string lazy to avoid create string.
9394c89 
2. add serializeVolatile api to avoid buffer copy which is 30% faster than serialize
3. remove the useLatin1 config which is standard in fury protocol
chaokunyang
chaokunyang approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theweipeng theweipeng merged commit 20f1849 into apache:main Jan 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaokunyang chaokunyang chaokunyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theweipeng @chaokunyang